Thomas Graf wrote: > You don't undo the allocations of __netlink_create if the > kmalloc for nlk->groups fails. So my question is if this is > intended and you really want to rely on the caller to invoke > sock_release() to free the sk again or whether it might be > worth to follow the rule of leave things untouched in case > of an error.
It was intentional, but I agree the other way around would be more consistent. If you want to send a patch, go ahead, otherwise I'll put it on my cleanup-list. Not allowing user sockets for unregistered protocols allows a couple of other cleanups as well. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
