> > So it is an optimization - not a bug then,
> correct?

It's a bug fix that happens to be an optimization :)

> No matter what you set skb->priority to, that gets
> translated
> by prio2band[] which should only point to actually
> initialized
> queues.

That's not correct. If prio_classify() sees that
TC_H_MAJ(skb->priority) equals the qdisc's handle, it
uses
TC_H_MIN(skb->priority)-1 as the band number. No
prio2band[]
involved. That's how the CLASSIFY iptables target (for
example) can set the band number.

I take that to be a feature of PRIO -- that you can
set the
band directly.

> If your netfilter module is accessing the PRIO qdisc
> data
> structures directly, you're not really supposed to
> do that.

I'm only setting skb->priority. It can even be done
(indirectly) from user space using setsockopt()
SO_PRIORITY option.

Amnon


__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to