David S. Miller wrote:
From: jamal <[EMAIL PROTECTED]>
Date: Tue, 10 Jan 2006 23:02:45 -0500
So it is an optimization - not a bug then, correct?
It is only an optimization in as much as it avoids duplicate
work during initialization.
Like you I don't see how this patch fixes anything.
No matter what you set skb->priority to, that gets translated
by prio2band[] which should only point to actually initialized
queues.
In the last case in prio_classify (band < q->bands) the band
is returned directly. This could come from attached filters
or from skb->priority. Its still not a fix since all bands
have at least noop-qdiscs attached to them, just a semantic
change which IMO makes sense.
If your netfilter module is accessing the PRIO qdisc data
structures directly, you're not really supposed to do that.
Why not design a cleaner interface in order to accomplish
whatever it is you're trying to achieve if that's what you
are doing?
I assume he's talking about the CLASSIFY target, which uses
skb->priority.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
