On 17/01/06, John W. Linville <[EMAIL PROTECTED]> wrote: > On Wed, Jan 04, 2006 at 09:33:27AM +1030, Graham Gower wrote: > > On 03/01/06, Patrick McHardy <[EMAIL PROTECTED]> wrote: > > > Graham Gower wrote: > > > > My logs were starting to fill with messages exatcly like that mentioned > > > > here: > > > > http://patchwork.netfilter.org/netfilter-devel/patch.pl?id=2840 > > > > > > > > In any event, the patch at the end of that link was never applied (it > > > > doesn't > > > > fix the other call to dev_kfree_skb). After applying my patch, I've not > > > > had any > > > > more messages in the logs. > > > > > > The patch has been applied to 2.6.15-rc. Only the first hunk of your > > > patch is still required, but it doesn't apply anymore. Can you send > > > a new patch against 2.6.15 please? > > > > > > > Ok, here's a new one. Hope I got it right this time. > > > > Signed-off-by: Graham Gower <[EMAIL PROTECTED]> > > > > --- linux-2.6.15/drivers/net/wireless/prism54/islpci_eth.c.orig > > +++ linux-2.6.15/drivers/net/wireless/prism54/islpci_eth.c > > @@ -177,7 +177,7 @@ > > #endif > > > > newskb->dev = skb->dev; > > - dev_kfree_skb(skb); > > + dev_kfree_skb_irq(skb); > > skb = newskb; > > } > > } > > - > > I'm planning to apply this patch with the following changelog commentary: > > [PATCH] prism54/islpci_eth.c: dev_kfree_skb used with interrupts disabled > > dev_kfree_skb should not be used with interrupts disabled. Change to > use dev_kfree_skb_irq instead. > > Is that alright w/ everyone?
Fine by me. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
