What was tested was the entire patch set which included the pre-fetch patch. Since there so much controversy over the pre-fetch patch let last time we moved that patch to the end of the patch set. Then we asked ourselves if we should send that patch out at all. We decided not to stir things up and leave that last patch (pre-fetch) out. This is what broke the patch set. So to make it less controversial we used the patch except we removed the actual pre-fetch calls from the patch and is now what has applied.
We do test the patch sets before they go out but this time because of what has been happening we really needed to get them accepted so we pulled that one out. This was a mistake on our part but we were trying to do what was best all the way around. We should have also tested without that last patch applied which we didn't do. We would have obviously caught this if we did. This didn't prove anything, we just wanted to explain what happened. We are sorry for the thrash. We are working on other policies and procedures to help stop things like this from happening in the future. Cheers, John ----------------------------------------------------------- "Those who would give up essential Liberty, to purchase a little temporary Safety, deserve neither Liberty nor Safety.", Benjamin Franklin 1755 > -----Original Message----- > From: David S. Miller [mailto:[EMAIL PROTECTED] > Sent: Wednesday, January 18, 2006 2:29 PM > To: Brandeburg, Jesse > Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; Kirsher, Jeffrey T; > Ronciak, John; netdev@vger.kernel.org > Subject: Re: e1000 breakage in Jeff's tree > > > From: Jesse Brandeburg <[EMAIL PROTECTED]> > Date: Wed, 18 Jan 2006 14:20:28 -0800 (Pacific Standard Time) > > > The root cause of the bug is that the receive routine was > in a bad state > > because we didn't submit our prefetch patch, which > unfortunately didn't > > have just prefetchy things in it. > > So did you actually test the original patches set you sent out? > > Because of how it fails, and the fact that this basically broke > e1000 for everyone, it is impossible for me to see a way in > which you actually tested the patches you submitted yet still > this bug slipped through. > > Prove me wrong. :-) > - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
