From: Herbert Xu <[EMAIL PROTECTED]> Date: Thu, 2 Feb 2006 22:25:54 +1100
> [IPV6]: Don't hold extra ref count in ipv6_ifa_notify > > Currently the logic in ipv6_ifa_notify is to hold an extra reference > count for addrconf dst's that get added to the routing table. Thus, > when addrconf dst entries are taken out of the routing table, we need > to drop that dst. However, addrconf dst entries may be removed from > the routing table by means other than __ipv6_ifa_notify. > > So we're faced with the choice of either fixing up all places where > addrconf dst entries are removed, or dropping the extra reference count > altogether. > > I chose the latter because the ifp itself always holds a dst reference > count of 1 while it's alive. This is dropped just before we kfree the > ifp object. Therefore we know that in __ipv6_ifa_notify we will always > hold that count. > > This bug was found by Eric W. Biederman. > > Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> Applied, thanks Herbert. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
