Hello!

> Ok, thanks for the reminder Hasso.
> so essentially at the moment the pid that will show up (if
> quagga added the v6 route) will be that of quagga, correct?

In the part, where v6 routes added via netlink it was a long expected
thing.. I was lazy in many places to pass identity of author of change
through the layers. Use of 0 was enough good replacement for bummers,
because you never can distinguish the report about change
made by you from a report made by kernel in any case.

What's about use of current->pid, they must be replaced with 0s,
I am sorry I did not search for this bug in net/ipv6...


> Same with v4 iirc? If yes, then isnt it logical that if ifconfig added
> an ip address it should naturally be ifconfig's pid that shows up (for
> consistency)?

I am afraid It is not logical and inconsistent and really breaks
netlink. :-)

Those nl_pid's are _addresses_ of netlink sockets. You cannot fill them
with random numbers.


> [1] I understand the point put forward by Alexey that: had he called
> that field "port" instead of "pid" when he created netlink, things would
> have had different semantics - I am just talking about consistency here.

The semantics is clear. nl_pid is not a pid. :-)

Alexey
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to