jamal wrote: > Would pfifo even be a fit? The current RED is byte-counting - thats why > you can map to the backlog of inner qdisc (since it keeps buyte counts). > I have seen proposals to make it packet counting though.
Yes, pfifo can be used since it also maintains a byte backlog counter, but RED's min and max still have to be specified in bytes. > With RED (as implemented) you _need_ a fifo of some sort which has a > upper threshold in byte count thats why bfifo was natural fit there. > However, sfq with your changes is also a fit since it provides the same > parametrization. You need neither a fifo nor a limit. All RED does is calculate the average queue occupancy and react on that based on the min and max parameters. The upper threshold is just there to have some fixed boundaries on delay and/or resource consumption. >>Not replacing it if it is zero is just a possibility for >>future users that don't want the default inner qdisc to say so, it >>doesn't change anything today since iproute doesn't allow a limit of >>zero. BTW, you ACKed the exact same change for TBF (Patch 03/05). >> > > I almost commented on TBF;-> but then handwaved that your TBF patch was > also fixing something else which broke by using the limit "signal". The bug was that the default qdisc was only added when no qdisc was present, ignoring any changed limits. > Maybe you could separate the fix of what was broken before with the new > "signalling". Why? The patch is easy to understand and clearly commented in the changelog entry. > The idea of replacing the inner qdisc is standard procedure - think of a > prio qdisc (which also comes in with built in bfifo) and you wanted it > to be a pfifo/RED/TBF instead. It would be preferable not to deviate > from this scheme. Again, it does have a regular graft operation. And also again, replacing the inner qdisc in the change operation is necessary to keep a backwards compatible meaning of limit. It is exactly what TBF does. Besides that, no other qdiscs destroy their inner qdiscs when changing class parameters, why do you insist that RED and TBF do so unless necessary? - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
