Hi Rob, 2016-03-02 19:33 GMT+01:00 Rob Herring <r...@kernel.org>: > On Fri, Feb 26, 2016 at 11:51:50AM +0100, Alexandre TORGUE wrote: >> Signed-off-by: Alexandre TORGUE <alexandre.tor...@gmail.com> >> >> diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.txt >> b/Documentation/devicetree/bindings/net/stm32-dwmac.txt >> new file mode 100644 >> index 0000000..67fceda >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.txt >> @@ -0,0 +1,40 @@ >> +STMicroelectronics STM32 / MCU DWMAC glue layer controller >> + >> +This file documents platform glue layer for stmmac. >> +Please see stmmac.txt for the other unchanged properties. >> + >> +The device node has following properties. >> + >> +Required properties: >> +- compatible: Should be "st,stm32-dwmac" to select glue, and >> + "snps,dwmac-3.50a" to select IP vesrion. >> +- clocks: Should contain the GMAC main clock, and tx clock >> +- compatible: Should be "st,stm32-dwmac" to select glue and >> + "snps,dwmac-3.50a" to select IP version. >> +- clocks: Should contain the MAC main clock >> +- clock-names: Should contain the clock names "stmmaceth". >> +- st,syscon : Should be phandle/offset pair. The phandle to the syscon node >> which >> + encompases the glue register, and the offset of the control >> register. >> + >> +Optional properties: >> +- clocks: Could contain: >> + - the tx clock, >> + - the rx clock >> +- clock-names: Could contain the clock names "tx-clk", "rx-clk" > > Either the IP block has 3 clocks or it has 1. If you have a case where 1 > clock feeds all 3 inputs, then list the clock 3 times.
I agree. I will move rx/tx clock to required properties and then send a v4. Regards. Alexandre > > Rob
