Re: [PATCH net-next v5] rtnetlink: add new RTM_GETSTATS message to dump link stats

[roopa]

On 4/18/16, 5:57 PM, David Miller wrote:
> From: Eric Dumazet <eric.duma...@gmail.com>
> Date: Mon, 18 Apr 2016 14:35:56 -0700
>
>> On Mon, 2016-04-18 at 14:10 -0700, Roopa Prabhu wrote:
>>
>>> +   if (filter_mask & IFLA_STATS_FILTER_BIT(IFLA_STATS_LINK_64)) {
>>> +           struct rtnl_link_stats64 *sp;
>>> +
>>> +           attr = nla_reserve(skb, IFLA_STATS_LINK_64,
>>> +                              sizeof(struct rtnl_link_stats64));
>>> +           if (!attr)
>>> +                   goto nla_put_failure;
>>> +
>>> +           sp = nla_data(attr);
>> Are you sure we have a guarantee that sp is aligned to u64 fields ?
>>
>> x86 does not care, but some arches would have a potential misalign
>> access here.
> I'll do some testing on sparc and deal with any fallout.
Thanks David. I will be happy to respin if you see problems.