From: Eric Dumazet <eric.duma...@gmail.com> Date: Mon, 18 Apr 2016 21:32:04 -0700
> On Mon, 2016-04-18 at 23:41 -0400, David Miller wrote: >> >> + /* Add a zero length NOP attribute so that the nla_data() >> + * of the IFLA_STATS64 will be 64-bit aligned. >> + */ >> +#ifndef HAVE_EFFICIENT_UNALIGNED_ACCESS >> + attr = nla_reserve(skb, IFLA_PAD, 0); >> + if (!attr) >> + return -EMSGSIZE; >> +#endif > > You must do this only if current skb->data alignment is not correct. I'll put an assertion there if it makes you happy. :-)