On Tue, 18 Apr 2006 22:32:04 +1000 Herbert Xu <[EMAIL PROTECTED]> wrote:
> Hi Dave: > > You're absolutely right about there being a problem with the TSO packet > trimming code. The cause of this lies in the tcp_fragment() function. > > When we allocate a fragment for a completely non-linear packet the > truesize is calculated for a payload length of zero. This means that > truesize could in fact be less than the real payload length. > > When that happens the TSO packet trimming can cause truesize to become > negative. This in turn can cause sk_forward_alloc to be -n * PAGE_SIZE > which would trigger the warning. > > I've copied the code you used in tso_fragment which should work here. > > Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> > > Everyone who's having the sk_forward_alloc warning problem should give > this patch a go to see if it cures things. > > Just in case this still doesn't fix it, could everyone please also verify > whether disabling SMP has any effect on reproducing this? > > Thanks, Please put this in the next -stable load... - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
