Rob Herring wrote:
Sounds like 2 different h/w. The compatible property should distinguish
this.
So I changed it to this:
- compatible : Should be "qcom,fsm9900-emac" or "qcom,qdf2432-emac",
depending on the version of the internal PHY.
"qcom,fsm9900-emac" is for v1, and "qcom,qdf2432-emac"
is for v2.
(and changed the code to match).
However, now this doesn't work look right any more:
The external phy child node:
- compatible : Should be "qcom,fsm9900-emac-phy".
- reg : The phy address
I was never crazy about this, because the external PHY is whatever
device it happens to be.
The phy driver uses of_mdiobus_register, which calls
of_mdiobus_child_is_phy(). Based on my reading of the code, I think I
should just drop the compatible property altogether. Because the way it
is now causes of_mdiobus_child_is_phy() to return false when it parses
that node.
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
