+ Rafael and Al, for ACPI help. Rob Herring wrote:
>+Optional properties: >+- phy-version : the version of the integrated emac phy, either 1 or 2.
Sounds like 2 different h/w. The compatible property should distinguish this.
So I implemented this in v8 of my driver, but it is causing problems for ACPI.
In ACPI, the equivalent to a compatible string is the HID, which is QCOM8070 for the EMAC. The problem is that it's very difficult, if not impossible, to create new HIDs for different versions of the same device.
The driver will primarily (if not exclusively) be used on ACPI platforms, not DT. In Qualcomm, DT is for mobile chips, and ACPI is for server. To my knowledge, there are no plans to use this driver on an actual DT-enabled platform, but I want to support DT anyway.
The other problem is that the "internal PHY" of the EMAC is technically a separate device, and it's interchangeable. Future versions of our chips will use different internal PHYs, but the EMAC will stay the same.
So I would like a solution that works on DT and ACPI. I suppose I could use compatible strings on DT, and a "phy-version" DSD (property) on ACPI. If that's acceptable to everyone, then I can do that. It seems clunky to me.
-- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
