Yes, I agree. Actually the main contribution of TCP Veno is not in this AI phase. No matter the ABC is added or not, TCP Veno can always improve the performance over wireless networks, according to our tests.
Best Regards, Zhou Bin -----Original Message----- From: Stephen Hemminger [mailto:[EMAIL PROTECTED] Sent: Thursday, May 25, 2006 12:47 AM To: Baruch Even Cc: #ZHOU BIN#; [EMAIL PROTECTED]; netdev@vger.kernel.org Subject: Re: [PATCH] TCP Veno module for kernel 2.6.16.13 On Wed, 24 May 2006 17:16:52 +0100 Baruch Even <[EMAIL PROTECTED]> wrote: > #ZHOU BIN# wrote: > > From: Bin Zhou <[EMAIL PROTECTED]> > > + else if (sysctl_tcp_abc) { > > + /* RFC3465: Apppriate Byte Count > > + * increase once for each full cwnd acked. > > + * Veno has no idear about it so far, so we keep > > + * it as Reno. > > + */ > > + if (tp->bytes_acked >= tp->snd_cwnd*tp->mss_cache) { > > + tp->bytes_acked -= tp->snd_cwnd*tp->mss_cache; > > + if (tp->snd_cwnd < tp->snd_cwnd_clamp) > > + tp->snd_cwnd++; > > + } > > You should prefer to ignore abc instead. At least that's what everyone > else is doing, the only place where abc is active is in NewReno. > > Baruch That was intentional. When ABC was added, the desire was to not change existing behavior for other congestion control methods. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html