Re: [PATCH v3 net-next 4/4] net/sched: act_mirred: Implement ingress actions

[Jamal Hadi Salim]

On 16-10-06 08:49 PM, Cong Wang wrote:

On Thu, Oct 6, 2016 at 5:17 PM, Jamal Hadi Salim <j...@mojatatu.com> wrote:

I dont believe we need to bother with the return code in  this case.

Why?

For a quick example, STOLEN vs. SHOT:

        result = tc_classify(skb, filter, &res, false);
        if (result >= 0) {
#ifdef CONFIG_NET_CLS_ACT
                switch (result) {
                case TC_ACT_STOLEN:
                case TC_ACT_QUEUED:
                        *qerr = NET_XMIT_SUCCESS | __NET_XMIT_STOLEN;
                case TC_ACT_SHOT:
                        return 0;
                }
#endif

Note, *qerr is the return value to ->enqueue().

You are right. I take back what i said.
We at minimal need consistency; so whether going to ingress or egress
we should at least increment the overlimit stats in case of non-success
code. Shmulik please fix up with checks on return code.

cheers,
jamal