From: [EMAIL PROTECTED] Date: Thu, 01 Jun 2006 20:32:26 -0700 > From: "Jari Takkala" <[EMAIL PROTECTED]> > > Fix a problem where output from /proc/net/arp skips a record when the full > output does not fit into the users read() buffer. > > To reproduce: publish a large number of ARP entries (more than 10 required > on my system). Run 'dd if=/proc/net/arp of=arp-1024.out bs=1024'. View > the output, one entry will be missing. > > Signed-off-by: Jari Takkala <[EMAIL PROTECTED]> > Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
This patch doesn't make any sense, I've been over it a few times. The seqfile layer should take care of that user buffering issue transparently as long as we implement the interface callbacks properly. Even if something needs to be fixed in the pneigh dumper, special casing *pos==1 doesn't look right. Also, if pneigh has this problem, how come the neigh seqfile iterators don't have the same problem or do they? - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html