On Sun, Jun 11, 2006 at 11:49:05PM -0700, David Miller wrote: > > Yeah. Good point. But how much protocol internals do we want to > slide into the ->data_ready() callbacks of such layers? That's ugly > and something we should try to avoid.
I agree with the objective of minimising the exposure of internals. However, in this particular instance we're already exposing much more than a couple of UDP SNMP counters in the sunrpc code. This makes adjusting the counters there the most expedient course of action. Longer term we probably want to restructure the code a bit so that more if it moves to udp.c. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
