From: Francois Romieu <rom...@fr.zoreil.com> Date: Fri, 13 Jan 2017 01:07:00 +0100
> Were alloc_skb moved one level up in the call stack, there would be > no need to use the new wait api in the subsequent page, thus easing > pre 3.19 longterm kernel maintenance (at least those on korg page). > > But it tastes a tad bit too masochistic. Lack of error handling of allocation failure is always a huge red flag. We even long ago tried to do something like this for TCP FIN handling. It's dumb, it doesn't work. Therefore I agree that the correct fix is to move the SKB allocation up one level to vcc_sendmsg() and make it handle errors properly.
