Re: [PATCH net-next v5 1/1] net sched actions: Add support for user cookies

[Jamal Hadi Salim]

On 17-01-22 01:13 PM, Florian Fainelli wrote:

+               a->act_cookie->data = nla_memdup(tb[TCA_ACT_COOKIE],
+                                                GFP_KERNEL);
+               if (!a->act_cookie->data) {
+                       err = -ENOMEM;
+                       tcf_hash_release(a, bind);
+                       goto err_mod;
+               }

Are not you leaking a->act_cookie here in case nla_memdup() fails here?

yes, I am. Thanks for catching this. V6 coming up.

cheers,
jamal