> > +static irqreturn_t mv88e6xxx_g2_watchdog_thread_fn(int irq, void *dev_id) > > +{ > > + u16 reg; > > + > > + struct mv88e6xxx_chip *chip = dev_id; > > + > > + mv88e6xxx_g2_read(chip, GLOBAL2_WDOG_CONTROL, ®); > > + > > + dev_info(chip->dev, "Watchdog event: %04x", reg); > > Should this be 0x%04x just to illustrate the value is hexadecimal? And
Yes, the prefix would make sense. > should this be dev_info_once()? Since the next action is to disable the interrupt, and there is no code path to reenable it, _once does not seem needed. And if for some reason the kernel log is spammed with these messages, i want to know. It means my interrupt handling code is badly broken! Andrew