From: Benjamin Herrenschmidt <b...@kernel.crashing.org> Date: Tue, 11 Apr 2017 21:13:45 +1000
> On Tue, 2017-04-11 at 13:57 +0300, Sergei Shtylyov wrote: >> Need {} here as well since the 1st branch has it -- see >> Documentation/process/coding-style.rst (the end of the section 3). > > Adding {} in that specific statements just makes things more > cluttered and less readable. > > I can find a ton of examples of > > if (...) { > multi lines > ... > } else if (...) > single_line() > > In existing kernel code. Existing practice not following the coding style rules does not dictate that it's OK to do so. > I'll fix it in a next spin if Dave wants it that way but otherwise > I'm keen to leave it as it is. Please fix this and respin. Meanwhile get the coding style rules changed if you disagree with them. A patch series review is not the place to argue about your disagreement with the coding style rules. Thanks.