On Tue, 2017-04-11 at 11:27 -0400, David Miller wrote: > > I'll fix it in a next spin if Dave wants it that way but otherwise > > I'm keen to leave it as it is. > > Please fix this and respin. > > Meanwhile get the coding style rules changed if you disagree with > them. A patch series review is not the place to argue about your > disagreement with the coding style rules.
I will fix. Note that I don't disagree with the rule as stated. However I'd like to point out that the rule doesn't precisely match the construct here as it's for a dangling single else while what I had here is an else if ... so it's open to intepretation :-) I also tend to disagree that coding style rules should be firm laws, imho they should be considered in context and broken if they render a given piece of code less clear. That said, I will respin. Cheers, Ben.
