On Wed, Jun 28, 2017 at 11:30 PM, Simon Horman
<[email protected]> wrote:
> From: Pieter Jansen van Vuuren <[email protected]>
> +nfp_flower_xmit_flow(struct net_device *netdev,
> + struct nfp_fl_payload *nfp_flow, u8 mtype)
> +{
> + u32 meta_len, key_len, mask_len, act_len, tot_len;
> + struct nfp_repr *priv = netdev_priv(netdev);
> + struct sk_buff *skb;
> + unsigned char *msg;
> +
> + meta_len = sizeof(struct nfp_fl_rule_metadata);
> + key_len = nfp_flow->meta.key_len;
> + mask_len = nfp_flow->meta.mask_len;
> + act_len = nfp_flow->meta.act_len;
> +
> + tot_len = meta_len + key_len + mask_len + act_len;
> +
> + /* Convert to long words as firmware expects
> + * lengths in units of NFP_FL_LW_SIZ.
> + */
> + nfp_flow->meta.key_len /= NFP_FL_LW_SIZ;
> + nfp_flow->meta.mask_len /= NFP_FL_LW_SIZ;
> + nfp_flow->meta.act_len /= NFP_FL_LW_SIZ;
better to use use x >>= 2 instead x /= 4
I saw it in other places across the patch/set
