From: Or Gerlitz > Sent: 29 June 2017 14:47 ... > > + nfp_flow->meta.key_len /= NFP_FL_LW_SIZ; > > + nfp_flow->meta.mask_len /= NFP_FL_LW_SIZ; > > + nfp_flow->meta.act_len /= NFP_FL_LW_SIZ; > > better to use use x >>= 2 instead x /= 4 > > I saw it in other places across the patch/set
Provided the values are unsigned it makes no difference.
Having 2 matching constants just makes the code harder to read.
David
