Re: [PATCH v5 01/14] net: pch_gbe: Mark Minnow PHY reset GPIO active low

[Andrew Lunn]

> @@ -2700,10 +2701,10 @@ static int pch_gbe_minnow_platform_init(struct 
> pci_dev *pdev)
>               return ret;
>       }
>  
> -     gpio_set_value(gpio, 0);
> -     usleep_range(1250, 1500);
>       gpio_set_value(gpio, 1);
>       usleep_range(1250, 1500);
> +     gpio_set_value(gpio, 0);
> +     usleep_range(1250, 1500);

Hi Paul

It would be better to rewrite and use the gpiod_ API. The GPIO core
would then handle active low/active high.

      Andrew