TX rate limit fields are unsigned (__u32).
Use %u and print_uint when printing.
Tested:
$ ip link set ens1 vf 1 rate 2294967296
$ ip link show |grep -iE "vf 1" | grep rate
before:
vf 1 MAC 00:00:00:00:00:00, tx rate -2000000000 (Mbps), max_tx_rate
-2000000000Mbps, ...
after:
vf 1 MAC 00:00:00:00:00:00, tx rate 2294967296 (Mbps), max_tx_rate
2294967296Mbps, ...
Fixes: 3fd86630876a ("iproute2: rework SR-IOV VF support")
Fixes: 8c29ae7cc249 ("ip link: Fix crash on older kernels when show VF dev")
Fixes: f89a2a05ffa9 ("Add support to configure SR-IOV VF minimum and maximum Tx
rate through ip tool")
Fixes: ae7229d5f99e ("ip: Add support for setting and showing SR-IOV virtual
funtion link params")
Fixes: d0e720111aad ("ip: ipaddress.c: add support for json output")
Signed-off-by: Tariq Toukan <tar...@mellanox.com>
---
v1 -> v2:
Fixed JSON output (print_uint) as well.
Updated commit message.
ip/ipaddress.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/ip/ipaddress.c b/ip/ipaddress.c
index d01d7030b442..0f4e1cd526bb 100644
--- a/ip/ipaddress.c
+++ b/ip/ipaddress.c
@@ -416,10 +416,10 @@ static void print_vfinfo(FILE *fp, struct rtattr *vfinfo)
}
if (vf_tx_rate->rate)
- print_int(PRINT_ANY,
- "tx_rate",
- ", tx rate %d (Mbps)",
- vf_tx_rate->rate);
+ print_uint(PRINT_ANY,
+ "tx_rate",
+ ", tx rate %u (Mbps)",
+ vf_tx_rate->rate);
if (vf[IFLA_VF_RATE]) {
struct ifla_vf_rate *vf_rate = RTA_DATA(vf[IFLA_VF_RATE]);
@@ -428,14 +428,14 @@ static void print_vfinfo(FILE *fp, struct rtattr *vfinfo)
if (is_json_context()) {
open_json_object("rate");
- print_int(PRINT_JSON, "max_tx", NULL, max_tx);
- print_int(PRINT_ANY, "min_tx", NULL, min_tx);
+ print_uint(PRINT_JSON, "max_tx", NULL, max_tx);
+ print_uint(PRINT_ANY, "min_tx", NULL, min_tx);
close_json_object();
} else {
if (max_tx)
- fprintf(fp, ", max_tx_rate %dMbps", max_tx);
+ fprintf(fp, ", max_tx_rate %uMbps", max_tx);
if (min_tx)
- fprintf(fp, ", min_tx_rate %dMbps", min_tx);
+ fprintf(fp, ", min_tx_rate %uMbps", min_tx);
}
}
--
1.8.3.1
