On 3/8/18 9:08 AM, Tariq Toukan wrote: > TX rate limit fields are unsigned (__u32). > Use %u and print_uint when printing. > > Tested: > $ ip link set ens1 vf 1 rate 2294967296 > $ ip link show |grep -iE "vf 1" | grep rate > > before: > vf 1 MAC 00:00:00:00:00:00, tx rate -2000000000 (Mbps), max_tx_rate > -2000000000Mbps, ... > > after: > vf 1 MAC 00:00:00:00:00:00, tx rate 2294967296 (Mbps), max_tx_rate > 2294967296Mbps, ... > > Fixes: 3fd86630876a ("iproute2: rework SR-IOV VF support") > Fixes: 8c29ae7cc249 ("ip link: Fix crash on older kernels when show VF dev") > Fixes: f89a2a05ffa9 ("Add support to configure SR-IOV VF minimum and maximum > Tx rate through ip tool") > Fixes: ae7229d5f99e ("ip: Add support for setting and showing SR-IOV virtual > funtion link params") > Fixes: d0e720111aad ("ip: ipaddress.c: add support for json output") > Signed-off-by: Tariq Toukan <tar...@mellanox.com> > --- > > v1 -> v2: > Fixed JSON output (print_uint) as well. > Updated commit message. >
change looks fine to me. As a bug fix seems like this should go to iproute2-master not -next.