On Thu, 22 Mar 2018 11:55:12 +0100, Jiri Pirko wrote: > enum devlink_attr { > /* don't change the order or add anything between, this is ABI! */ > DEVLINK_ATTR_UNSPEC, > @@ -224,6 +242,7 @@ enum devlink_attr { > DEVLINK_ATTR_DPIPE_TABLE_RESOURCE_ID, /* u64 */ > DEVLINK_ATTR_DPIPE_TABLE_RESOURCE_UNITS,/* u64 */ > > + DEVLINK_ATTR_PORT_FLAVOUR, /* u16 */ > DEVLINK_ATTR_PORT_NUMBER, /* u32 */ > DEVLINK_ATTR_PORT_SPLIT_SUBPORT_NUMBER, /* u32 */
nit: why is it OK to add the attr in the middle of enum?