Hi, "Brown, Aaron F" <aaron.f.br...@intel.com> writes:
[...] > >> >> I added that note in the hope that someone else would have an stronger >> opinion about what to do. > > I don't have a strong opinion beyond my preference for an ideal world > where everything works :) If the part simply cannot filter on the src > address as a whole without the protocol I would ideally prefer an > attempt in ethtool to set the filter on src address as a whole to > return an error WHILE still allowing the filter to be set on an > ethertype when the proto keyword is issued. If ethtool does not allow > that fine grain of control then I think the way it is now is good, I'd > rather have the annoyance of being able to set a filter that does > nothing then not be able to set the more specific filter at all. We are agreed. The next version of this series implements just that: specifying the src address alone is an error, but if the classifier has a src address and any other filter, it works. Cheers, -- Vinicius
