Re: [PATCH net-next v11 03/10] netdev: cavium: octeon: Add Octeon III BGX Ethernet Nexus

[Andrew Lunn]

> +             /* Connect to PKI/PKO */
> +             data = oct_csr_read(BGX_CMR_CONFIG(numa_node, interface, port));
> +             if (is_mix)
> +                     data |= BIT(11);
> +             else
> +                     data &= ~BIT(11);
> +             oct_csr_write(data, BGX_CMR_CONFIG(numa_node, interface, port));
> +

Hi Steven

This driver has quite a lot of magic BIT macros. Can you add some
#defines with useful names?

         Thanks
                Andrew