Jeff Garzik wrote:
On Thu, Oct 26, 2006 at 01:11:55PM -0600, Matthew Wilcox wrote:
The motivator for this was to fix the sparse warning:
drivers/net/e100.c:2418:48: warning: cast truncates bits from constant
value (83126e978d4fdf becomes 978d4fdf)
drivers/net/e100.c:2419:37: warning: cast truncates bits from constant
value (83126e978d4fdf becomes 978d4fdf)
Initially, I tried a quick fix, but when it ran into difficulties, I
looked at tg3.c to see how it does it. I liked their way better, so I
rewrote e100.c to be similar. It shaves ~700 bytes off the size of the
driver, and a few bytes off the size of struct nic, so I think it's a
win all round. Tested on the internal interface of an HP Integrity rx2600.
Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]>
Seems sane to me... I'll pick it up, if Auke doesn't...
no objections, so I'll ACK it with the notion that I'm going to let our labs do some
more testing on it with all the latest changes to it.
Jeff, I will stack it on the patches I have for 2.6.20 and push those out before the
weekend.
Cheers,
Auke
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
