Re: [net-next 7/7] net/mlx5e: Improve ethtool private-flags code structure

[Cong Wang]

On Tue, Dec 4, 2018 at 10:27 PM Saeed Mahameed <sae...@mellanox.com> wrote:
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en.h 
> b/drivers/net/ethernet/mellanox/mlx5/core/en.h
> index a429553002a6..49e90ac5dc8b 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en.h
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en.h
...
>  #define MLX5E_SET_PFLAG(params, pflag, enable)                 \
>         do {                                                    \
>                 if (enable)                                     \
> -                       (params)->pflags |= (pflag);            \
> +                       (params)->pflags |= BIT(pflag);         \
>                 else                                            \
> -                       (params)->pflags &= ~(pflag);           \
> +                       (params)->pflags &= ~(BIT(pflag));      \
>         } while (0)
>

Please #include <linux/bits.h> explicitly.

Thanks.