On Wed, 2018-12-05 at 11:28 -0800, Cong Wang wrote: > Hello, Saeed > > On Tue, Dec 4, 2018 at 10:27 PM Saeed Mahameed <sae...@mellanox.com> > wrote: > > static int mlx5e_handle_pflag(struct net_device *netdev, > > u32 wanted_flags, > > - enum mlx5e_priv_flag flag, > > - mlx5e_pflag_handler pflag_handler) > > + enum mlx5e_priv_flag flag) > > { > ... > > if (err) { > > netdev_err(netdev, "%s private flag 0x%x failed err > > %d\n", > > enable ? "Enable" : "Disable", flag, > > err); > > As flag is now a true enum, you probably don't want to print it out > as hex > any more. >
Good point, i guess we can print mlx5e_priv_flags[flag].name thank you Cong ! > Thanks.