Here's my reasoning:
old = ct->ext;
//... stuff that doesn't change old.
alloc = max(newlen, NF_CT_EXT_PREALLOC); <-- will be >= 128,
so not zero
kmemleak_not_leak(old);
new = __krealloc(old, alloc, gfp);
if (!new)
return NULL; <--- if we return here, ct->ext still
holds old, so no leak.
if (!old) {
memset(new->offset, 0, sizeof(new->offset));
ct->ext = new; <--- old is NULL so can't leak
} else if (new != old) {
kfree_rcu(old, rcu); <-- we free old, so doesn't leak
rcu_assign_pointer(ct->ext, new);
} <--- else new == old && it's still in ct->ext, so it doesn't leak
Basically AFAICT our use of __krealloc() is exactly like krealloc()
except instead of kfree() we do kfree_rcu().
And thus I don't understand the need for kmemleak_not_leak(old).
So... what's my mistake?
