> -----Original Message----- > From: Jakub Kicinski <[email protected]> > Sent: Monday, August 24, 2020 12:43 PM > To: Nguyen, Anthony L <[email protected]> > Cc: [email protected]; Michael, Alice <[email protected]>; > [email protected]; [email protected]; [email protected]; > Kirsher, Jeffrey T <[email protected]>; Brady, Alan > <[email protected]>; Burra, Phani R <[email protected]>; Hay, > Joshua A <[email protected]>; Chittim, Madhu > <[email protected]>; Linga, Pavan Kumar > <[email protected]>; Skidmore, Donald C > <[email protected]>; Brandeburg, Jesse > <[email protected]>; Samudrala, Sridhar > <[email protected]> > Subject: Re: [net-next v5 01/15] virtchnl: Extend AVF ops > > On Mon, 24 Aug 2020 10:32:52 -0700 Tony Nguyen wrote: > > +struct virtchnl_rss_hash { > > + u64 hash; > > + u16 vport_id; > > +}; > > + > > +VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_rss_hash); > > I've added 32bit builds to my local setup since v4 was posted - looks like > there's > a number of errors here. You can't assume u64 forces a 64bit alignment. Best > to > specify the padding explicitly. > > FWIW these are the errors I got but there may be more: >
It seems like these are triggering on old messages too, curious why this wasn't caught sooner. Will fix, thanks. -Alan
