> -----Original Message----- > From: Jakub Kicinski <[email protected]> > Sent: Monday, August 24, 2020 1:41 PM > To: Nguyen, Anthony L <[email protected]> > Cc: [email protected]; Michael, Alice <[email protected]>; > [email protected]; [email protected]; [email protected]; > Kirsher, Jeffrey T <[email protected]>; Brady, Alan > <[email protected]>; Burra, Phani R <[email protected]>; Hay, > Joshua A <[email protected]>; Chittim, Madhu > <[email protected]>; Linga, Pavan Kumar > <[email protected]>; Skidmore, Donald C > <[email protected]>; Brandeburg, Jesse > <[email protected]>; Samudrala, Sridhar > <[email protected]> > Subject: Re: [net-next v5 04/15] iecm: Common module introduction and > function stubs > > On Mon, 24 Aug 2020 10:32:55 -0700 Tony Nguyen wrote: > > +static inline bool > > +iecm_tx_singleq_clean_all(struct iecm_q_vector *q_vec, int budget) { > > + /* stub */ > > +} > > Still a lot of static inlines throughout. Are they making any difference? The > compiler will inline static functions, anyway.
We haven't profiled the inlines to verify they're doing anything, perhaps just some misguided preemptive performance attempt. We can remove them. Will fix. -alan
