> -----Original Message-----
> From: Jiri Pirko <[email protected]>
> Sent: Friday, September 4, 2020 5:41 PM
> To: Sunil Kovvuri Goutham <[email protected]>
> Cc: Jakub Kicinski <[email protected]>; [email protected];
> [email protected]; [email protected]; Subbaraya Sundeep
> Bhatta <[email protected]>
> Subject: Re: [EXT] Re: [net-next PATCH 0/2] Introduce mbox tracepoints for
> Octeontx2
>
> Fri, Sep 04, 2020 at 10:49:45AM CEST, [email protected] wrote:
> >
> >
> >> -----Original Message-----
> >> From: Jiri Pirko <[email protected]>
> >> Sent: Friday, September 4, 2020 2:07 PM
> >> To: Sunil Kovvuri Goutham <[email protected]>
> >> Cc: Jakub Kicinski <[email protected]>; [email protected];
> >> [email protected]; [email protected]; Subbaraya Sundeep
> Bhatta
> >> <[email protected]>
> >> Subject: Re: [EXT] Re: [net-next PATCH 0/2] Introduce mbox
> >> tracepoints for
> >> Octeontx2
> >>
> >> Fri, Sep 04, 2020 at 07:39:54AM CEST, [email protected] wrote:
> >> >
> >> >
> >> >> -----Original Message-----
> >> >> From: Jakub Kicinski <[email protected]>
> >> >> Sent: Friday, September 4, 2020 12:48 AM
> >> >> To: [email protected]
> >> >> Cc: [email protected]; [email protected]; Sunil Kovvuri
> >> >> Goutham <[email protected]>; Subbaraya Sundeep Bhatta
> >> >> <[email protected]>
> >> >> Subject: [EXT] Re: [net-next PATCH 0/2] Introduce mbox tracepoints
> >> >> for
> >> >> Octeontx2
> >> >>
> >> >> External Email
> >> >>
> >> >> ------------------------------------------------------------------
> >> >> ---
> >> >> - On Thu, 3 Sep 2020 12:48:16 +0530 [email protected] wrote:
> >> >> > From: Subbaraya Sundeep <[email protected]>
> >> >> >
> >> >> > This patchset adds tracepoints support for mailbox.
> >> >> > In Octeontx2, PFs and VFs need to communicate with AF for
> >> >> > allocating and freeing resources. Once all the configuration is
> >> >> > done by AF for a PF/VF then packet I/O can happen on PF/VF
> queues.
> >> >> > When an interface is brought up many mailbox messages are sent
> >> >> > to AF for initializing queues. Say a VF is brought up then each
> >> >> > message is sent to PF and PF forwards to AF and response also
> >> >> > traverses
> >> from AF to PF and then VF.
> >> >> > To aid debugging, tracepoints are added at places where messages
> >> >> > are allocated, sent and message interrupts.
> >> >> > Below is the trace of one of the messages from VF to AF and AF
> >> >> > response back to VF:
> >> >>
> >> >> Could you use the devlink tracepoint? trace_devlink_hwmsg() ?
> >> >
> >> >Thanks for the suggestion.
> >> >In our case the mailbox is central to 3 different drivers and there
> >> >would be a 4th one once crypto driver is accepted. We cannot add
> >> >devlink to all of them inorder to use the devlink trace points.
> >>
> >> I guess you have 1 pci device, right? Devlink instance is created per
> >> pci device.
> >>
> >
> >No, there are 3 drivers registering to 3 PCI device IDs and there can
> >be many instances of the same devices. So there can be 10's of instances of
> AF, PF and VFs.
>
> So you can still have per-pci device devlink instance and use the tracepoint
> Jakub suggested.
>
Two things
- As I mentioned above, there is a Crypto driver which uses the same mbox APIs
which is in the process of upstreaming. There also we would need trace points.
Not sure registering to devlink just for the sake of tracepoint is proper.
- The devlink trace message is like this
TRACE_EVENT(devlink_hwmsg,
. . .
TP_printk("bus_name=%s dev_name=%s driver_name=%s incoming=%d type=%lu
buf=0x[%*phD] len=%zu",
__get_str(bus_name), __get_str(dev_name),
__get_str(driver_name), __entry->incoming, __entry->type,
(int) __entry->len, __get_dynamic_array(buf), __entry->len)
);
Whatever debug message we want as output doesn't fit into this.
Thanks,
Sunil.
