David Miller <da...@davemloft.net> writes:

From: Shay Agroskin <shay...@amazon.com>
Date: Sun, 13 Sep 2020 11:16:34 +0300

ENA logs are adjusted to display the full ENA representation to
distinct each ENA device in case of multiple interfaces.
Using dev_err/warn/info function family for logging provides uniform
printing with clear distinction of the driver and device.

This patch changes all printing in ena_com files to use dev_* logging messages. It also adds some log messages to make driver debugging
easier.

Signed-off-by: Amit Bernstein <amitb...@amazon.com>
Signed-off-by: Shay Agroskin <shay...@amazon.com>

This device prefix is so much less useful than printing the actual
networking adapter that the ena_com operations are for.

So if you are going to do this, go all the way and pass the ena_adapter or the netdev down into these ena_com routines so that you can use
the netdev_*() message helpers.

Thank you.

Thanks you for reviewing it. Some of the ena_com functions are called with dev* routines because the netdev struct isn't created when they
are executed.

We'll go over the other ena com routines (which are called when an
interface exists) and change them to netdev_* routines instead. I'll send a new version of the patchset once done.

Reply via email to