> -----Original Message----- > From: Patrick McHardy [mailto:[EMAIL PROTECTED] > Sent: Thursday, June 28, 2007 12:37 PM > To: Jeff Garzik > Cc: Waskiewicz Jr, Peter P; [EMAIL PROTECTED]; > netdev@vger.kernel.org; Kok, Auke-jan H; [EMAIL PROTECTED] > Subject: Re: [PATCH 2/3] NET: [CORE] Stack changes to add > multiqueue hardware support API > > Jeff Garzik wrote: > > Patrick McHardy wrote: > > > >> Yes, but there are users that don't go through qdiscs, > like netpoll, > >> Having them check the QDISC_RUNNING bit seems ugly. > > > > > > Is netpoll the only such user? > > I'm not sure, I just remembered that one :) > > Looking at Peter's multiqueue patch, which should include all > hard_start_xmit users (I'm not seeing sch_teql though, > Peter?) the only other one is pktgen.
Ugh. That is another netif_queue_stopped() that needs netif_subqueue_stopped(). I can send an updated patch for the core to fix this based from your patches Patrick. > > > netpoll tends to be a special case in every sense of the > word, and I > > wish it was less so :/ > > Indeed. So what do we do about netpoll then wrt netif_(sub)queue_stopped() being removed from qdisc_restart()? The fallout of having netpoll() cause a queue to stop (queue 0 only) is the skb sent will be requeued, since the driver will return NETIF_TX_BUSY if this actually happens. But this is a corner case, and we won't lose packets; we'll just have increased latency on that queue. Should I worry about this or just move forward with the sch_teql.c change and repost the core patch? Thanks, -PJ Waskiewicz - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
