On Sat, 2007-07-21 at 11:54 -0700, David Miller wrote: > From: Rusty Russell <[EMAIL PROTECTED]> > Date: Sat, 21 Jul 2007 18:00:11 +1000 > > > No, I was just thinking that drivers will put the napi_struct in their > > driver-specific struct (eg. struct e1000_adapter *adapter = > > container_of(container_of(napi, struct e1000_adapter, napi);). > > That works. > > > Multi-queue drivers will have no use for a napi_struct in net_device, > > right? They'll need some wrapper "my_queue" structure containing the > > napi_struct anyway. > > Sure, we can eliminate the napi_struct in struct net_device > eventually. > > But then again, like the statistics, if it's convenient to > just use the in-net_device one then why not :)
Because *every* single driver can use the in-net_device stats. In five years' time, the "napi_struct for simple drivers" in net_device will look confusing. Since your change touches all NAPI drivers anyway, it'd be nice to go straight to "everyone allocates their own NAPI struct" in one jump. Cheers, Rusty. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
