From: Rusty Russell <[EMAIL PROTECTED]> Date: Sun, 22 Jul 2007 09:10:23 +1000
> In five years' time, the "napi_struct for simple drivers" in net_device > will look confusing. Since your change touches all NAPI drivers anyway, > it'd be nice to go straight to "everyone allocates their own NAPI > struct" in one jump. Good point. But note that you'd be adding a pointer deref, the current sequence: napi_struct --> netdev --> driver_private involves all pointer arithmetic and no derefs, whereas: napi_struct --> driver_private --> netdev will involve at least on deref to get to the netdev from the driver_private. (Ignore the fact that netdev_priv() is not currently optimized as it used to be, that's an abberation of the current multi-queue implementation and will be fixed). So this suggestion does have real downsides. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
