On Tue, 2007-10-16 at 15:16 -0700, David Miller wrote: > And it's unfortunately buggy. > > For example, the sky2_suspend() code iterates over the ports > and calls sky2_down() on each one that is up. > > That will call napi_disable() on the same NAPI instance if > multiple ports are up, and thus hang the machine. > > This is why, Stephen, for the second time, I'm telling you > that perhaps you should put the NAPI instance into the > sky2_port struct.
Can sky2 send/mask interrupts separately per port ? The reason why I can't do that with EMAC is why I'm doing multiple ports per NAPI instance... If sky2 sticks to doing like EMAC, then it probably also needs to do like EMAC which is to have it's own port_disable/enable that use local per-port disable bits. (It may do a real napi_disable when all ports are disabled, I suppose, though I don't currently do it in EMAC). Ben. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
