On Sun, Dec 16, 2007 at 07:06:41PM +0100, Jarek Poplawski wrote: > > It seemed to exist a few days ago: > http://kerneltrap.org/mailarchive/linux-netdev/2007/12/4/473123 > > Btw., I don't know which of the patches: Eric's or yours will be chosen, > but, IMHO, there is no reason to remove rtnl_trylock(), which can be still > useful, just like mutex_trylock() is.
Doh! Andrew was too convincing :) I misread the grep result on in_interrupt. Of course that function returns true if we're either in an IRQ handler or have BH off. I retract what I've said in this thread and continue to oppose this change without a might_sleep. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
