Wang Chen <[EMAIL PROTECTED]> wrote: > In tree net-2.6.25, commit "96793b482540f3a26e2188eaf75cb56b7829d3e3" > made a mistake. > > In that patch, David L added a icmp_out_count() in ip_push_pending_frames(), > remove icmp_out_count() from icmp_reply(). But he forgot to remove > icmp_out_count() from icmp_send() too. > Since icmp_send and icmp_reply will call icmp_push_reply, which will call > ip_push_pending_frames, a duplicated increment happened in icmp_send.
Actually having the icmp_out_count call in ip_push_pending_frames seems inconsistent. Having it there means that we count raw socket ICMP packets too. But we don't do that for any other protocol, e.g., raw UDP packets don't get counted. So was the inclusion of raw ICMP packets intentional? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
