David Stevens <[EMAIL PROTECTED]> wrote:
>
>        The patch was to support the ICMPMsgStats table. Since none of 
> certain
> types of output ICMP messages are generated by the kernel, but are 
> required
> by the RFC, counting raw sockets is intentional (and the only way those 
> ICMP
> types can be counted at all).
>        Raw UDP packets would not be counted either before or after the 
> patch,
> but aren't part of the ICMPMsgStats table. Adding those might be 
> worthwhile,
> but it isn't quite the hole that the ICMP out stats were, since there is a
> cooked interface for UDP output that counts the common use, at least.

Fair enough.  How about moving this code back into icmp.c and just
add a new count call in raw.c? The push pending function is used on
the UDP fast path so the leaner it is the better.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to