On Wed, Apr 22, 2015 at 3:27 PM, Alexei Starovoitov <a...@plumgrid.com> wrote: > On 4/21/15 10:05 PM, Cong Wang wrote: >> >> On Tue, Apr 21, 2015 at 12:27 PM, Alexei Starovoitov <a...@plumgrid.com> >> wrote: >>> >>> introduce tc_classify_act() and qdisc_drop_bypass() helper functions to >>> reduce >>> copy-paste among different qdiscs >> >> >> >> I don't think qdisc_drop_bypass() is more readable than without it, >> maybe you need a better name, or just leave the code as it is. > > > what would be a better name? I'm open to suggestions.
My reading for "qdisc_drop_bypass()" is it bypasses packet dropping for some case, apparently doesn't match its definition. I can't think out a better name therefore I don't think it deserves a function, just leave as it is. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
