key_basic is set twice in __skb_flow_dissect which seems unnecessary.
Remove second one.

Signed-off-by: Tom Herbert <t...@herbertland.com>
---
 net/core/flow_dissector.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
index 4a2cb93..6aebe99 100644
--- a/net/core/flow_dissector.c
+++ b/net/core/flow_dissector.c
@@ -343,12 +343,6 @@ flow_label:
                break;
        }
 
-       /* It is ensured by skb_flow_dissector_init() that basic key will
-        * be always present.
-        */
-       key_basic = skb_flow_dissector_target(flow_dissector,
-                                             FLOW_DISSECTOR_KEY_BASIC,
-                                             target_container);
        key_basic->n_proto = proto;
        key_basic->ip_proto = ip_proto;
        key_basic->thoff = (u16) nhoff;
-- 
1.8.1

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to