Corinna Vinschen <vinsc...@redhat.com> : > The r8169 driver collects statistical information returned by > @get_stats64 by counting them in the driver itself, even though many > (but not all) of the values are already collected by tally counters > (TCs) in the NIC. Some of these TC values are not returned by > @get_stats64. Especially the received multicast packages are missing > from /proc/net/dev. > Rectify this by fetching the TCs and returning them from > rtl8169_get_stats64.
It is not exactly a some / many / not all / confused [*] picture - get_stats64 provides software managed values - ethtool provides hardware only values [*] ok, rx_missed is kinda special. > The counters collected in the driver obviously disappear as soon as the > driver is unloaded so after a driver is loaded the counters always start > at 0. The TCs are only reset by a power cycle and there's no known way > to reset them programatically. Without further considerations the values > collected by the driver would not match up against the TC values. I'd rather: 1. keep software and hardware stats separated 2. push to userspace the responsibility to offset device specific hardware values jumps My 0.02 €. -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
