On Aug 19 09:31, Hayes Wang wrote: > Corinna Vinschen [mailto:vinsc...@redhat.com] > > Sent: Wednesday, August 19, 2015 5:13 PM > [...] > > > It could be cleared by setting bit 0, such as rtl_tally_reset() of r8152. > > > > Is it safe to assume that this is implemented in all NICs covered by r8169? > > It is supported from RTL8111C. That is, RTL_GIGA_MAC_VER_19 and later.
Thanks. In that case I would prefer the same generic method for all chip versions, so I'd opt for storing the offset values at rtl_open time as my patch is doing right now. Is that acceptable? If so, wouldn't it make even more sense to use the hardware collected information in @get_stats64 throughout, except for the numbers collected *only* in software? I would be willing to propose a matching patch. Thanks, Corinna
pgpJydjgGbJe7.pgp
Description: PGP signature
